Convert ChildExecutionInfo Persistence POGOs to Proto #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jul 28, 2020
| SignalRequestedIDs: response.State.SignalRequestedIDs, | ||
| ReplicationState: response.State.ReplicationState, | ||
| Checksum: response.State.Checksum, | ||
| ChildExecutionInfos: response.State.ChildExecutionInfos, |
Contributor
There was a problem hiding this comment.
ChildExecutionInfos wasn't there at all?
Contributor
Author
There was a problem hiding this comment.
See the part I removed below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
ChildExecutionInfoandInternalChildExecutionInfofrom thepersistencepkg. MovedmutableStateand the persistence interface to usepersistenceblobs.ChildExecutionInfo.started_eventandinitiated_event; instead use correctHistoryEventproto typeWhy?
workflowMutableStateneeds to become a proto objectHow did you test it?
Existing
maketestsPotential risks
Wide test coverage on timeouts should catch this, behavioral changes are contained within persistence.