Convert ReplicationState/ExecutionState POGO to Proto #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jul 28, 2020
Comment on lines
+45
to
+58
| // ExecutionStats is not persisted and is used internally and as part of mutableState | ||
| message ExecutionStats { | ||
| int64 history_size = 1; | ||
| } | ||
|
|
||
| // ReplicationState represents mutable state information for global namespaces. | ||
| // This information is used by replication protocol when applying events from remote clusters | ||
| // (not persisted) | ||
| message ReplicationState { | ||
| int64 current_version = 1; | ||
| int64 start_version = 2; | ||
| int64 last_write_version = 3; | ||
| int64 last_write_event_id = 4; | ||
| map<string, temporal.server.api.replication.v1.ReplicationInfo> last_replication_info = 5; |
Contributor
There was a problem hiding this comment.
I think they should be moved to another proto packages (i.e. workflow and replication) but I will do it myself later.
alexshtin
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Converted ReplicationState/ExecutionState POGO to Proto. Defined in Persistenceblobs with notation that these are not currently persisted, though they are exposed by the persistence contracts.
Why?
Need these defined as protos for eventual conversion of WorkflowMutableState to Proto.
How did you test it?
Current testing, Buildkite
Potential risks
None, field replacements to proto with no behavioral changes