Use 0 as value for EmptyEventID which represents Unspecified #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jul 30, 2020
| BufferedEventID int64 = -123 | ||
| // EmptyEventTaskID is uninitialized id of the task id within event | ||
| EmptyEventTaskID int64 = -1234 | ||
| EmptyEventTaskID int64 = 0 |
Contributor
There was a problem hiding this comment.
This is not what title says.
samarabbas
force-pushed
the
empty-event-id-to-zero
branch
from
40121e1 to
c86993c
Compare
alexshtin
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Use 0 as value for EmptyEventID which represent value not being set
Why?
Previously we used a special value
-23to represent value for EventID is not not set.After moving to protobuf we now use
0as the value which represents Unspecified throughout the codebase.For consistency moving to
0as the value for EmptyEventID.How did you test it?
Unit and Integration tests.
Potential risks
Medium Risk.