Default LatestTime to Now in ListOpen/CloseWorkflowExecutions #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service/frontend/workflowHandler.go
Outdated
| } | ||
|
|
||
| if timestamp.TimeValue(request.GetStartTimeFilter().GetLatestTime()).IsZero() { | ||
| request.GetStartTimeFilter().LatestTime = timestamp.TimeNowPtrUtc() |
Contributor
There was a problem hiding this comment.
Time.max() instead of Time.now() because of possible clock skew?
There was a problem hiding this comment.
i wonder if it might also make sense
- to have the frontend just leave the values as is, and
- to let whoever is actually handling the request to interpret IsZero values as "no upper bound", and produce the data accordingly.
Contributor
Author
There was a problem hiding this comment.
"Whoever" is persistence layer and we have 4 different calls to it. I will have to modify it in 4 places, or just one (here). I agree frontend handler is not a best place for it. Although all our validation/default logic is in frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
LatestTimeonStartTimeFilteris default to UTC now inListOpen/CloseWorkflowExecutionsAPIs.Why?
Default it to zero time makes no sense.
How did you test it?
Run tests.
Potential risks
No risks.