Make 0 as invalid value for failover Version #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmptyVersion has the value 0 and this means Version is not set. Make sure all math around Version computation does not treat 0 as valid value.
alexshtin
reviewed
Jul 31, 2020
| EmptyEventID int64 = -23 | ||
| // EmptyVersion is used as the default value for failover version when no value is provided | ||
| EmptyVersion int64 = -24 | ||
| EmptyVersion int64 = 0 |
alexshtin
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
EmptyVersion has the value 0 and this means Version is not set.
Make sure all math around Version computation does not treat 0 as
valid value.
Why?
As part of converting everything to protobuf we are treating default value for integer fields to
represent value is not set. Which means Version value of 0 means it is unspecified and should
not represent a valid value in the system.
How did you test it?
unit and integration test
Potential risks