Fix refresh namespace cache errors #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Aug 3, 2020
Comment on lines
-399
to
-401
| if err := h.grpcListener.Close(); err != nil { | ||
| h.logger.WithTags(tag.Error(err)).Error("failed to close gRPC listener") | ||
| } |
Contributor
Author
There was a problem hiding this comment.
It turn out that when we close server it closed underlying listener itself, so this line always generated and error.
| c.logger.Error("Error refreshing namespace cache", tag.Error(err)) | ||
| time.Sleep(NamespaceCacheRefreshFailureRetryInterval) | ||
|
|
||
| if _, opened := <-c.shutdownChan; !opened { |
Contributor
Author
There was a problem hiding this comment.
Exit immediately if error occured and shutdown channel is closed. For some reason (I don't quite understand why) it did stuck here before.
samarabbas
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Noisy integration tests errors are disappeared.
How did you test it?
Run tests.
Potential risks
No risks.