Fixes bug where terminating a parent with a lot of child workflows that continue-as-new doesn't propagate terminate to children #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
reviewed
Aug 27, 2020
samarabbas
requested changes
Aug 27, 2020
Contributor
samarabbas
left a comment
samarabbas
left a comment
There was a problem hiding this comment.
Need to include FirstExecutionRunID with terminate request.
…fix_termination_cancellation_large_number_child_workflows
…ws' of github.com:mastermanu/temporal into fix_termination_cancellation_large_number_child_workflows
samarabbas
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ParentClosePolicy Workflow was passing in the first run ID of a child workflow getting executed. This is problematic because if the child workflow is continued as new, the termination attempt will fail as that particular instance of the child execution is already completed.
This change was made because a Workflow with a lot of Child Workflows (more than the ParentClosePolicyThreshold setting) will not successfully terminate (or cancel) any Workflows that are continued as new.
Tested locally via the bench test.
STILL TODO: Investigating if we can add an integration test to exercise the ParentClosePolicy Workflow.
Low-risk as the intent of terminating a workflow is to cascade to its children for ParentClosePolicy = Terminate