Skip to content

Skip BufferedEvents persistence when empty #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Skip BufferedEvents persistence when empty #707

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae81805
Don't persist BufferedEvents if empty
shawnhathaway Sep 1, 2020
db3619f
Merge branch 'master' into nill_buff_events
shawnhathaway Sep 1, 2020
6d4d1eb
Update common/persistence/executionStore.go
shawnhathaway Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/persistence/executionStore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ func (m *executionManagerImpl) SerializeWorkflowMutation(
}

var serializedNewBufferedEvents *serialization.DataBlob
if input.NewBufferedEvents != nil {
if input.NewBufferedEvents != nil && len(input.NewBufferedEvents) > 0 {
serializedNewBufferedEvents, err = m.serializer.SerializeBatchEvents(input.NewBufferedEvents, encoding)
if err != nil {
return nil, err
Expand Down