Skip to content

Conversation

@shawnhathaway
Copy link
Contributor

What changed?

  • Expose SQL Connection Options in docker template
  • Note MySQL did not have any values set here previously

Why?
Should be user configurable.

How did you test it?
No testing, looking at buildkite and pipeline stabilization.

Potential risks
Connection starvation

Copy link

@markmark206 markmark206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't test this, and didn't verify that the values get picked up by the server, but otherwise the changes look good to me.

note that our helm chart don't currently use config_template.yaml, they generate config files "manually", so if we want systems deployed with helm charts to have access to this, that code needs to be updated as well.
https://github.com/temporalio/helm-charts/blob/3e59a5230768972e50fed8834ba4d1377a0dc8fe/templates/server-configmap.yaml#L94

@shawnhathaway shawnhathaway merged commit d86d7e2 into temporalio:master Sep 2, 2020
@shawnhathaway shawnhathaway deleted the mysql_conn branch September 2, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants