Fix wrong field #721
Merged
Fix wrong field #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publicClient port should be frontend rpc Port
config is inconsistent with code
alexshtin
approved these changes
Sep 11, 2020
Contributor
alexshtin
left a comment
alexshtin
left a comment
There was a problem hiding this comment.
It makes sense for consistency but these ports are not used for worker role at all.
Contributor
Author
|
I noticed that the service actually works, so i think this field is not used, but I'm not sure. Maybe we can rearrange the configuration file, otherwise it looks confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
local NDC config
Why?
config is inconsistent with code
How did you test it?
build NDC services locally
Potential risks
local config, no risks