Remove GetRawHistoryV1 api used for 2dc #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Sep 20, 2020
| // this function poll events from history side | ||
| pageSize := 1 | ||
| getHistory := func(namespace string, execution *commonpb.WorkflowExecution, firstEventID int64, nextEventID int64, | ||
| token []byte) (*adminservice.GetWorkflowExecutionRawHistoryResponse, error) { |
Contributor
There was a problem hiding this comment.
i would suggest delete this function (TestAdminGetWorkflowExecutionRawHistory_All) all together and file a ticket to create an integration test for v2 get raw history API
v2 api also takes in the version of start / end history event:
Contributor
Author
There was a problem hiding this comment.
Yeah ran into this. Removing these tests for now. Filed: #745
Contributor
|
LGTM |
alexshtin
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.