Skip to content

Conversation

@mastermanu
Copy link
Member

@mastermanu mastermanu commented Sep 24, 2020

  • The EnableBatcher default value was set to false, which meant that batch commands would be accepted by the server, but never actually processed.
  • For Temporal clusters with Elastic Search enabled, but without explicit dynamic configuration, key fields such as CustomNamespace, Operator, KafkaKey and Encoding were not registered as "indexed." This would cause any attempt to start the batch command to fail as the server would think we were performing an elastic search query on an unindexed field
  • Adds missing ES index setup for "Encoding" key
  • Cleans up a tiny bit of Batcher code/comments based on adhoc code-review

Change was verified through standard unit/integration test pipeline + manual validation of batch commands for starting (cancel, terminate, signal), terminating, describing, and listing

No risks unless the batching feature when enabled can cause issues for existing clusters. Verified that worker role is not affected if batching workflows are registered even for a cluster w/o ElasticSearch

@mastermanu mastermanu merged commit a94be76 into temporalio:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants