Implement post reset operations #7719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gow
force-pushed
the
cg/reset_move_version
branch
3 times, most recently
from
c059a09 to
580dc8a
Compare
This reverts commit 265ae72e149a844cbecbc95fca7a7fe02878e13e.
Contributor
Author
|
Merging this for now. |
gow
added a commit
to temporalio/cli
that referenced
this pull request
Jul 9, 2025
<!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Added reset subcommands so that we can do reset + update version info atomically in one operation. The server changes were made in temporalio/temporal#7719. This is the CLI counterpart. To allow subcommands we added a new flag `subcommands-optional`. When this flag is present a parent command can be run in isolation without any subcommands (i.e subcommands will be optional) ## Why? So that we can reset + update_version at the same time. ## Checklist <!--- add/delete as needed ---> 1. Closes: <!-- add issue number here --> N/A 2. How was this tested: Added tests + manually tested 3. Any docs updates needed? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds PostResetOperation support to reset API. With this we will be performing certain operations after reset. In this PR
Why?
Developers/Operators often want to perform certain operations soon after resetting a workflow. Ex: updating worker version, sending signal to workflow etc. These operations need to be performed atomically along with the reset operation.
How did you test it?