Skip to content

Conversation

@hai719
Copy link
Contributor

@hai719 hai719 commented May 27, 2025

What changed?

use (runID, child initiated event id & version) as unique requestID to start child workflow.

Why?

For event-based replication, request_id is not replicated to standby clusters. Standby cannot dedup the start workflow request if failover happens. By using (runID, child initiated event id & version) as requestID, it will be unique across clusters.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

@hai719 hai719 requested review from xwduan, yux0 and yycptt May 27, 2025 17:18
@hai719 hai719 marked this pull request as ready for review May 27, 2025 17:18
@hai719 hai719 requested a review from a team as a code owner May 27, 2025 17:18
@hai719 hai719 marked this pull request as draft May 27, 2025 23:38
@hai719 hai719 changed the title add request_id in child initiated event use (runID, child initiated event id & version) as unique requestID to start child workflow May 28, 2025
@hai719 hai719 marked this pull request as ready for review May 29, 2025 17:17
@hai719 hai719 requested a review from yycptt May 29, 2025 17:17
@hai719 hai719 merged commit 72cd2fd into main May 29, 2025
57 checks passed
@hai719 hai719 deleted the hai719/request_id branch May 29, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants