Fix max deployment count check to not block new versions #7841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
reviewed
Jun 2, 2025
Member
There was a problem hiding this comment.
adding new versions to existing deployment
I did a quick pass and i'm going to do one more soon, but the changes seem to be related to Listing workflow executions; how is/was this preventing adding new versions to deployment?
Member
There was a problem hiding this comment.
was wrong - ignore the above comment - reviewing again
Shivs11
approved these changes
Jun 2, 2025
Member
Shivs11
left a comment
Shivs11
left a comment
There was a problem hiding this comment.
hopefully fixes the breaking canaries!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The check to enforce number of Worker Deployments remain within the limit for a NS could also prevent adding new versions to existing deployments when user has just enough deployments that reach the limit but not exceed it.
Why?
Fixing unexpected behavior.
How did you test it?
Potential risks
None.