Skip to content

fixing workflow_query_success_count tag mismatch #7847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

fixing workflow_query_success_count tag mismatch #7847

merged 1 commit into from
Jun 2, 2025

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jun 2, 2025

What changed?

  • nightly pipelines caught that the workflow_query_success_count was being emitted with variable tag key for non user-defined query types

Why?

  • to make these pipelines pass

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

  • None

@Shivs11 Shivs11 requested a review from a team as a code owner June 2, 2025 13:49
@Shivs11 Shivs11 merged commit 4014a25 into main Jun 2, 2025
56 checks passed
@Shivs11 Shivs11 deleted the ss/fix-tag-mismatch branch June 2, 2025 21:25
temporal-cicd bot added a commit that referenced this pull request Jun 3, 2025
@temporal-cicd
Patch PR #7847 into cloud/v1.28.0-134
6a36354
@temporal-cicd temporal-cicd bot mentioned this pull request Jun 3, 2025
Merged
Shivs11 pushed a commit that referenced this pull request Jun 3, 2025
@temporal-cicd
Patch PR #7847 into cloud/v1.28.0-134 (#7862)
92c7cc9 
Commit changes from pull request (#7847) into cloud/v1.28.0-134
0bce2a4 - fix tag mismatch:

Co-authored-by: temporal-cicd[bot] <temporal-cicd[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlydf carlydf carlydf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shivs11 @carlydf