Do not set sticky queue if a transition is ongoing #7852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
approved these changes
Jun 3, 2025
Shivs11
pushed a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When an auto-upgrade workflow moves to another deployment version, it clears the sticky queue from mutable state. But an edge case is possible in which a wf task is already started on the old version and will complete later, after the sticky queue is cleared. In this case we should ensure the completed wf task does not set the sticky queue again to the old worker.
Why?
This bug causes the workflow to get stuck with a transition that does not complete.
How did you test it?
Potential risks
None. Should be added to the patch.