Skip to content

Do not bypass task generation when version changes #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Do not bypass task generation when version changes #7890

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ea69d0
Do not bypass task generation when version changes
ShahabT Jun 10, 2025
9acab45
compare using transition
ShahabT Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions service/history/api/respondworkflowtaskcompleted/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,13 @@ func (handler *WorkflowTaskCompletedHandler) Invoke(
}
}
}
pollerDeployment := worker_versioning.DeploymentFromDeploymentVersion(worker_versioning.DeploymentVersionFromOptions(request.GetDeploymentOptions()))
wfDeployment := ms.GetEffectiveDeployment()
if !pollerDeployment.Equal(wfDeployment) {
// Do not return new wft to worker if it's version does not match wf's
// let the task go through matching and get dispatched to the right worker
bypassTaskGeneration = false
}

var newWTErr error
// If we checked WT heartbeat timeout before and WT wasn't timed out,
Expand Down
Loading