Update DeploymentName from Override and fix batch UpdateOptions serialization bug #7910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…override deployment
ShahabT
approved these changes
Jun 13, 2025
lina-temporal
pushed a commit
that referenced
this pull request
Jun 26, 2025
…lization bug (#7910) ## What changed? Update DeploymentName from Override and fix batch UpdateOptions serialization bug Also added back the deleted UpdateOptions tests ## Why? - ExecutionInfo.DeploymentName should contain the deployment that the wf is running on - Batch move needs to work ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s) ## Potential risks This locks us into supporting the deprecated override fields for at least 2 weeks longer, but that's fine IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update DeploymentName from Override and fix batch UpdateOptions serialization bug
Also added back the deleted UpdateOptions tests
Why?
How did you test it?
Potential risks
This locks us into supporting the deprecated override fields for at least 2 weeks longer, but that's fine IMO