Skip to content

Conversation

@feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Oct 5, 2020

What changed?
WorkflowTaskFailed event now renders failure in human readable form (top level failure + stack trace + some of deeper lvl failures)

Why?
Adds visibility into WorkflowTaskFailed data

How did you test it?
Tests + ran command
image

Potential risks
no risks

@feedmeapples feedmeapples requested a review from alexshtin October 5, 2020 17:57
@feedmeapples feedmeapples requested a review from wxing1292 October 5, 2020 19:46
Copy link
Contributor

@wxing1292 wxing1292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to format the stack trace?

@feedmeapples
Copy link
Contributor Author

is it possible to format the stack trace?

there is an option to add custom handler for objects of type Failure. i'll add under the same work item and separate PR

@feedmeapples feedmeapples merged commit c2d50b8 into temporalio:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants