Adding mutable metadata and cluster id #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Oct 6, 2020
wxing1292
reviewed
Oct 6, 2020
schema/mysql/v57/temporal/versioned/v1.1/mutable_cluster_metadata.sql
Outdated
Show resolved
Hide resolved
wxing1292
reviewed
Oct 6, 2020
wxing1292
reviewed
Oct 6, 2020
schema/postgresql/temporal/versioned/v1.1/mutable_cluster_metadata.sql
Outdated
Show resolved
Hide resolved
wxing1292
reviewed
Oct 6, 2020
Contributor
wxing1292
left a comment
wxing1292
left a comment
There was a problem hiding this comment.
plz also add corresponding tests here:
https://github.com/temporalio/temporal/blob/master/common/persistence/persistence-tests/clusterMetadataManagerTest.go
wxing1292
approved these changes
Oct 6, 2020
Contributor
wxing1292
left a comment
wxing1292
left a comment
There was a problem hiding this comment.
plz add some tests before landing
alexshtin
approved these changes
Oct 6, 2020
wxing1292
reviewed
Oct 7, 2020
wxing1292
reviewed
Oct 7, 2020
wxing1292
reviewed
Oct 7, 2020
wxing1292
reviewed
Oct 7, 2020
wxing1292
reviewed
Oct 7, 2020
…ng it instead of immutable metadata
vitarb
force-pushed
the
version-info-boilerplate
branch
from
6fdec9b to
9e0b8b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to have have unique stable cluster id stored in the database and also provides ability to store any other cluster specific data alongside without having to fear that we will override immutable data.
It also allows changing mutability of certain fields in code when needed.
Previously all cluster metadata was immutable containing only cluster name (from the config) and shard count. This limited its usability as it was impossible to add new fields (e.g. cluster id) to it as well as store mutable components like latest available version.
In the first attempt I've tried to add another blob alongside immutable metadata but quickly realized that keeping it would result in messy code due to lack of clear boundary between mutable and immutable.
As a result I've decided to refactor existing implementation and move immutability check on application layer at the same time adding versioning to the storage.
Change was tested locally using persistence test and manually on cassandra/mysql.