improvement: bypass middle-man-struct for batch operations

proto/internal/temporal/server/api/batch/v1/request_response.proto

@@ -3,38 +3,24 @@ syntax = "proto3";
 package temporal.server.api.batch.v1;
 option go_package = "go.temporal.io/server/api/batch/v1;batch";
 
-import "google/protobuf/duration.proto";
-
 import "temporal/api/workflowservice/v1/request_response.proto";
-import "temporal/api/common/v1/message.proto";
-
-message BatchOperation {
-  // The namespace of the batch operation.
-  string namespace = 1;
-
-  // The query to perform.
-  string query = 2;
-
-  repeated temporal.api.common.v1.WorkflowExecution workflow_executions = 3;
-
-  string reason = 4;
+import "google/protobuf/duration.proto";
 
-  BatchOperationInput input = 5;
+message BatchOperation { 
+  string namespace_id = 1; 
 
-  double rps = 6;
+  double rps = 2;
 
-  int64 concurrency = 7;
+  int64 concurrency = 3;
 
-  int64 attempts_on_retryable_error = 8;
+  int64 attempts_on_retryable_error = 4;
 
-  google.protobuf.Duration activity_heartbeat_timeout = 9;
+  google.protobuf.Duration activity_heartbeat_timeout = 5;
 
-  repeated string non_retryable_errors = 10;
+  repeated string non_retryable_errors = 6;
 
-  string batch_type = 11;
-}
+  string batch_type = 7;
 
-message BatchOperationInput { 
-  string namespace_id = 1; 
-  temporal.api.workflowservice.v1.StartBatchOperationRequest request = 2;
+  // The request to start the batch operation.
+  temporal.api.workflowservice.v1.StartBatchOperationRequest request = 8;
 }

service/frontend/workflow_handler.go

@@ -4504,14 +4504,9 @@ func (wh *WorkflowHandler) StartBatchOperation(
 	}
 
 	input := &batchspb.BatchOperation{
-		Query:     request.GetVisibilityQuery(),
-		Reason:    request.GetReason(),
-		Namespace: request.GetNamespace(),
-		Input: &batchspb.BatchOperationInput{
-			Request: request,
-		},
-		WorkflowExecutions: request.GetExecutions(),
-		Rps:                float64(request.GetMaxOperationsPerSecond()),
+		Request:     request,
+		NamespaceId: namespaceID.String(),
+		Rps:         float64(request.GetMaxOperationsPerSecond()),
 	}
 
 	var identity string
@@ -4541,10 +4536,10 @@ func (wh *WorkflowHandler) StartBatchOperation(
 		switch a := op.UnpauseActivitiesOperation.GetActivity().(type) {
 		case *batchpb.BatchOperationUnpauseActivities_Type:
 			unpauseCause := fmt.Sprintf("%s = 'property:activityType=%s'", searchattribute.TemporalPauseInfo, a.Type)
-			input.Query = fmt.Sprintf("(%s) AND (%s)", visibilityQuery, unpauseCause)
+			input.Request.VisibilityQuery = fmt.Sprintf("(%s) AND (%s)", visibilityQuery, unpauseCause)
 		case *batchpb.BatchOperationUnpauseActivities_MatchAll:
 			wildCardUnpause := fmt.Sprintf("%s STARTS_WITH 'property:activityType='", searchattribute.TemporalPauseInfo)
-			input.Query = fmt.Sprintf("(%s) AND (%s)", visibilityQuery, wildCardUnpause)
+			input.Request.VisibilityQuery = fmt.Sprintf("(%s) AND (%s)", visibilityQuery, wildCardUnpause)
 		}
 	case *workflowservice.StartBatchOperationRequest_ResetActivitiesOperation:
 		input.BatchType = batcher.BatchTypeResetActivities