Skip to content

improvement: remove waits before fetching activities #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 13, 2025
Merged

improvement: remove waits before fetching activities #8144

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
592ee81
improvement: remove waits before fetching activities
spkane31 Aug 4, 2025
f34e239
fixing syntax errors
spkane31 Aug 4, 2025
0e75fed
adding correct paging to the protobuf impl
spkane31 Aug 4, 2025
dabab71
davids comments on old pr
spkane31 Aug 4, 2025
c1910cb
remove workflow type filter
spkane31 Aug 4, 2025
1e9fbf5
use an event loop and put heartbeat details into its own goroutine
spkane31 Aug 5, 2025
c40798f
Merge branch 'main' of github.com:temporalio/temporal into spk/improv…
spkane31 Aug 5, 2025
b69b82f
workflow execution passed correctly
spkane31 Aug 5, 2025
f92fba4
remove heartbeatdetails from task, unexport page, reference page in t…
spkane31 Aug 5, 2025
03d7295
rename
spkane31 Aug 5, 2025
1211f1e
remove comment
spkane31 Aug 5, 2025
6d04029
addressing roeys comments
spkane31 Aug 12, 2025
e12d4c9
Merge branch 'main' of github.com:temporalio/temporal into spk/improv…
spkane31 Aug 12, 2025
f6856ab
removing duplication with done method
spkane31 Aug 12, 2025
f379f5f
Update service/worker/batcher/activities.go
spkane31 Aug 13, 2025
795d208
Merge branch 'main' into spk/improve-batch-workers
spkane31 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion service/frontend/workflow_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4815,9 +4815,11 @@ func (wh *WorkflowHandler) ListBatchOperations(
Namespace: request.GetNamespace(),
PageSize: request.PageSize,
NextPageToken: request.GetNextPageToken(),
Query: fmt.Sprintf("%s = '%s' and %s = '%s'",
Query: fmt.Sprintf("(%s = '%s' or %s = '%s') and %s = '%s'",
searchattribute.WorkflowType,
batcher.BatchWFTypeProtobufName,
searchattribute.WorkflowType,
batcher.BatchWFTypeName,
searchattribute.TemporalNamespaceDivision,
batcher.NamespaceDivision,
),
Expand Down
Loading
Loading