allow nil/unversioned ramping version if current version is already nil/unversioned and ramp percentage is 0 #8172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsioned-ramp-and-unversioned-current
carlydf
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…rsioned-ramp-and-unversioned-current
yiminc
reviewed
Sep 3, 2025
Shivs11
requested changes
Sep 4, 2025
…rsioned-ramp-and-unversioned-current
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…rsioned-ramp-and-unversioned-current
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Shivs11
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
allow nil/unversioned ramping version if current version is already nil/unversioned and ramp percentage is 0
Why?
So that people can revert a task queue back to unversioned state without needing to set a 0% ramped non-nil Ramping Version.
How did you test it?