Skip to content

Decode of nil data #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

Decode of nil data #8179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions common/persistence/serialization/codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ func Decode(data *commonpb.DataBlob, result proto.Message) error {
if data == nil {
return NewDeserializationError(enumspb.ENCODING_TYPE_UNSPECIFIED, errors.New("cannot decode nil"))
}
if data.Data == nil {
return nil
}

switch data.EncodingType {
case enumspb.ENCODING_TYPE_JSON:
Expand Down
10 changes: 10 additions & 0 deletions common/persistence/serialization/codec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ func TestProtoDecode(t *testing.T) {
assert.Contains(t, err.Error(), "cannot decode nil")
})

t.Run("empty data blob", func(t *testing.T) {
blob := &commonpb.DataBlob{}

var result persistencespb.ShardInfo
err := Decode(blob, &result)
require.Error(t, err)
assert.IsType(t, &UnknownEncodingTypeError{}, err)
assert.Contains(t, err.Error(), "unknown or unsupported encoding type Unspecified")
})

t.Run("nil data field", func(t *testing.T) {
blob := &commonpb.DataBlob{
Data: nil,
Expand Down
Loading