Revert PR 8081 changes in service/frontend directory only #8186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
approved these changes
Aug 12, 2025
5 tasks
This reverts the batch operation changes from PR 8081 (#8081) but only for files in the service/frontend directory, restoring the original BatchParams-based implementation.
spkane31
force-pushed
the
spk/revert-frontend-8081
branch
from
9353935 to
80e82db
Compare
bergundy
approved these changes
Aug 12, 2025
Co-authored-by: Roey Berman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the batch operation changes from PR 8081 (#8081) but only for files in the service/frontend directory, restoring the original BatchParams-based implementation.
What changed?
Revert #8081 frontend changes.
Why?
This change is not backwards compatible, in the future we can turn on the protobuf workflow
How did you test it?
Potential risks
Minimal, we're reverting the breaking change w/ this PR