Record various activity metrics #8196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changes activity metrics
Deprecated Metrics
New & Replacement Metrics
timeout_type. Aligned with the existing workflow_timeout counter.timeout_type.Why?
ActivityE2ELatency is inaccurate, since it measures only individual attempts. The other metrics are not recorded yet.
How did you test it?
Ran the server locally and checked the metrics in Prometheus:
Test 1: Activity with 5 attempts (1s each, 1s gap, all time out)
Test 2: Basic helloworld activity
Test 3: Activity with 5 attempts (1s each, 1s gap, all fail except for the last one)