Adding automated version check on server #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Oct 9, 2020
wxing1292
reviewed
Oct 9, 2020
wxing1292
reviewed
Oct 9, 2020
wxing1292
reviewed
Oct 9, 2020
wxing1292
reviewed
Oct 9, 2020
wxing1292
approved these changes
Oct 9, 2020
Contributor
wxing1292
left a comment
wxing1292
left a comment
There was a problem hiding this comment.
plz provide some tests before landing
alexshtin
reviewed
Oct 9, 2020
alexshtin
reviewed
Oct 9, 2020
alexshtin
approved these changes
Oct 10, 2020
vitarb
force-pushed
the
version-reporting
branch
from
106face to
197dd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a version checker deamon that will upon startup and every 24 hours collect version guidance from the version-info service and will store it in the database.
This feature will be enabled by default. It's possible to turn it off by either setting
TEMPORAL_DISABLE_VERSION_CHECKenv var or by usingfrontend.enableServerVersionCheckdynamic config property.