Skip to content

fix: handle nil ptr in batch processing #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

fix: handle nil ptr in batch processing #8240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628943b
fix: handle nil ptr in batch processing
spkane31 Aug 26, 2025
7cdb5f7
remove log stmt
spkane31 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion service/worker/batcher/activities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,10 @@ func startTaskProcessorProtobuf(
}
var err error

if task.execution == nil {
continue
}

switch operation := batchOperation.Request.Operation.(type) {
case *workflowservice.StartBatchOperationRequest_TerminationOperation:
err = processTask(ctx, limiter, task,
Expand Down Expand Up @@ -904,7 +908,6 @@ func processTask(
task task,
procFn func(*commonpb.WorkflowExecution) error,
) error {

err := limiter.Wait(ctx)
if err != nil {
return err
Expand Down
Loading