Skip to content

Conversation

@bergundy
Copy link
Member

@bergundy bergundy commented Oct 24, 2025

What

Used the depguard linter to prevent importing the package and modified all uses of it.

Also fixed a bug in the membership code where we were not updating the next page token:
https://github.com/temporalio/temporal/pull/8541/files#diff-985dd64ffa4c6bfe0248b982dc47439b725862baa3e1f2c559b7ff522bf21969R350

Why?

From the package README in GitHub:

This package now leverages the github.com/google/uuid package (which is based off an earlier version of this package).

Also, there's no point in having two uuid implementations in the codebase.

Test

Added the invalid import and confirmed it works:

../service/frontend/admin_handler_test.go:13:2: import 'github.com/pborman/uuid' is not allowed from list 'main': Importing github.com/pborman/uuid is disallowed; use github.com/google/uuid instead (depguard)
        _ "github.com/pborman/uuid"

@bergundy bergundy requested review from a team as code owners October 24, 2025 21:34
@bergundy bergundy force-pushed the no-pborman-uuid branch 2 times, most recently from d823811 to 8ddb7fd Compare October 24, 2025 22:38
Copy link
Contributor

@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time please separate the renames and other logical changes into separate commits to make it easier to review

@bergundy bergundy enabled auto-merge (squash) November 26, 2025 01:09
@bergundy bergundy merged commit 78caede into temporalio:main Nov 26, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants