Add CHASM visibility task handling of alias to field mapping for custom search attributes #8558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om search attributes
rodrigozhou
approved these changes
Nov 12, 2025
bergundy
reviewed
Nov 12, 2025
|
|
||
| for alias, value := range aliasedSearchAttributes { | ||
| fieldName, err := searchAttributesMapper.GetFieldName(alias, namespaceEntry.Name().String()) | ||
| if err != nil { |
Member
There was a problem hiding this comment.
I thought we said we would log these errors since search attributes can be removed and we don't want to fail the visibility task for this.
Contributor
Author
There was a problem hiding this comment.
yea, this should not fail the task executor, will address this in a follow up
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CHASM visibility task handling of alias to field mapping for custom search attributes. The Visibility component stores aliased custom search attributes and their corresponding payloads.
On the WRITE path, Visibility Store CURRENTLY assumes search attributes are schema field names, and does not apply any mappings from alias -> field. This is because FrontEnd "Unaliases" to its field names before sending to History.
What changed?
Before calling the visibility manager
UpsertWorkflowExecution, the search attributes need to be mapped from their aliases to their field names.Why?
Support Visibility component compatibility with current Visibility Store implementation.
How did you test it?