CHASM: Fix validation context #8562
Merged
+74
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina-temporal
approved these changes
Nov 4, 2025
yycptt
force-pushed
the
chasm-fix-task-validation-ctx
branch
from
b2e5314 to
e1a1a61
Compare
pdoerner
pushed a commit
that referenced
this pull request
Nov 25, 2025
## What changed? - Use immutable chasm context to access node when doing validations ## Why? - Validation doesn't change component state and nothing needs to be persisted. - Some parts of the system skips persistence when component access fail on validation step, if node is marked dirty, a dirty mutable state panic will be triggered upon releasing the execution lock. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?