Skip to content

Suppress noisy timer related log #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2020
Merged

Suppress noisy timer related log #860

merged 3 commits into from
Oct 15, 2020

Conversation

@wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Oct 15, 2020

What changed?

  • Chang log level from warn to debug if timer to be created is less than current min timer cursor and postponed

Why?
Logging becomes noisy and operator can rely on CPU utilization / load metrics instead of this logging

How did you test it?
Make bins

Potential risks
N/A

@wxing1292 wxing1292 requested a review from a team October 15, 2020 00:14
@wxing1292 wxing1292 merged commit 548af47 into temporalio:master Oct 15, 2020
@wxing1292 wxing1292 deleted the logging branch October 15, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@markmark206 markmark206 markmark206 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wxing1292 @markmark206