Skip to content

Conversation

@chaptersix
Copy link
Contributor

@chaptersix chaptersix commented Nov 23, 2025

What changed?

Allows the service the server binary starts to be controls by the TEMPORAL_SERVICES environment variable.

Why?

Allows us to remove the shell scripts from the server docker image.

Breaking Change: the script currently supports : as a list separator but this does not

Testing

===  Single environment variable value ===
+ API_KEY=from-env ./flagtest
Resolved api-key: [from-env] (1 values)

=== Multiple comma-separated values in ENV ===
+ API_KEY=key1,key2,key3 ./flagtest
Resolved api-key: [key1 key2 key3] (3 values)

=== Multiple comma-separated values in CLI arg ===
+ ./flagtest --api-key=cli1,cli2,cli3
Resolved api-key: [cli1 cli2 cli3] (3 values)

=== CLI argument overrides ENV variable (single values) ===
+ API_KEY=from-env ./flagtest --api-key=from-cli
Resolved api-key: [from-cli] (1 values)

=== Multiple --api-key arguments ===
+ ./flagtest --api-key=first --api-key=second --api-key=third
Resolved api-key: [first second third] (3 values)

=== Mixed: multiple args with comma-separated values ===
+ ./flagtest --api-key=a1,a2 --api-key=b1,b2
Resolved api-key: [a1 a2 b1 b2] (4 values)

@chaptersix chaptersix marked this pull request as ready for review November 24, 2025 17:49
@chaptersix chaptersix requested review from a team as code owners November 24, 2025 17:49
@chaptersix
Copy link
Contributor Author

This change is require for removing the SERVICES flag from the start up script. #8671

@chaptersix chaptersix requested a review from bergundy November 24, 2025 21:59
@chaptersix chaptersix merged commit a6aa9bc into main Nov 25, 2025
58 checks passed
@chaptersix chaptersix deleted the alex/svc-env branch November 25, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants