-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Spelling Errors #8686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chaptersix
wants to merge
17
commits into
main
Choose a base branch
from
alex/spell-corrections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix Spelling Errors #8686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add crate-ci/typos spell checker to the project for automatic spell checking: - Add _typos.toml configuration in .github/ (next to golangci config) - Exclude generated protobuf files (*.pb.go, *.proto, etc.) - Add typos job to GitHub Actions linters workflow - Add lint-typos and lint-typos-changed targets to Makefile - lint-typos-changed checks only files changed from main (fast for local dev) - Integrate lint-typos-changed into main lint target for faster local runs - Document inline ignore directives and --file-list usage in config The spell checker will run in CI on all files, while local make lint will only check changed files for better performance.
Added exceptions for intentional "misspellings" and false positives: - Preemptable (used instead of Preemptible for caller types) - ba, Ue, nd, abd (test data and hash strings) - AVAILABILTY (backwards-compatible environment variable) - Heartbeart/heartbeart (proto-generated field names - need proto fix first) - SVG file exclusion (hex color codes trigger false positives) - testdata directory exclusion - json.gz file exclusion These exceptions prevent the typo linter from flagging legitimate code patterns and test data while still catching real spelling errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Bulk fix of spelling errors.
Why?
Follow up to this PR: #8495