Prevent workflow task and activity task generation when workflow is paused #8687
+97
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler.go
Outdated
Show resolved
Hide resolved
spkane31
approved these changes
Nov 24, 2025
| err = s.SdkClient().SignalWorkflow(ctx, workflowID, runID, s.testEndSignal, "signal to complete the workflow") | ||
| s.NoError(err) | ||
|
|
||
| time.Sleep(2 * time.Second) // wait 2 seconds to give enough time record the signal. |
Contributor
There was a problem hiding this comment.
Is the sleep required with the s.EventuallyWithT below?
Contributor
There was a problem hiding this comment.
There's also a failure in tests that needs to be fixed but lgtm
yycptt
reviewed
Nov 24, 2025
Comment on lines
+513
to
+515
| } else { // if not we bypass activity task generation if eager start activity is requested. | ||
| bypassActivityTaskGeneration = eagerStartActivity | ||
| } |
Member
There was a problem hiding this comment.
nit: looks like the else part is a duplication of L509.
| // Create a transfer task to schedule a workflow task | ||
| if !mutableState.HasPendingWorkflowTask() { | ||
| // Create a transfer task to schedule a workflow task only if the workflow is in running status and there is no pending workflow task. | ||
| if !mutableState.HasPendingWorkflowTask() && mutableState.GetExecutionState().GetStatus() == enumspb.WORKFLOW_EXECUTION_STATUS_RUNNING { |
Member
There was a problem hiding this comment.
I don't think workflow tasks scheduled on the task processing side goes through this code path.
Contributor
Author
There was a problem hiding this comment.
hmmm.. maybe intercepting in the task generator is the better? Specifically in TaskGeneratorImpl.GenerateScheduleWorkflowTaskTasks().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
When a workflow is paused, we should not generate any more new activity and workflow tasks.
How did you test it?
Note
Prevents scheduling new workflow and activity tasks while a workflow is paused and adds functional tests covering pause/unpause behavior with activities and child workflows.
service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler.gobypassTaskGenerationto skip activity task creation wheneagerStartActivityor workflow status isWORKFLOW_EXECUTION_STATUS_PAUSED.service/history/api/update_workflow_util.goWORKFLOW_EXECUTION_STATUS_RUNNING.tests/pause_workflow_execution_test.goPAUSEDafter activity completion and after receiving a signal; verify it completes afterUNPAUSE.Written by Cursor Bugbot for commit 25a4b89. This will update automatically on new commits. Configure here.