Clean up Nexus CHASM completion code #8692
Merged
+76
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spkane31
approved these changes
Nov 24, 2025
chasm/nexus_completion.go
Outdated
| // callbacks. Particularly useful for components that want to track a workflow start with StartWorkflowExecution. | ||
| func GenerateNexusCallback(ctx Context, component Component) (*commonpb.Callback, error) { | ||
| if _, ok := component.(NexusCompletionHandler); !ok { | ||
| return nil, errors.New("component must implement HandleNexusCompletion") |
Contributor
There was a problem hiding this comment.
Didn't catch this on my PRs, but this error message looks wrong
Suggested change
| return nil, errors.New("component must implement HandleNexusCompletion") | |
| return nil, errors.New("component must implement NexusCompletionHandler") |
Member
Author
There was a problem hiding this comment.
Yeah, that's fine because it's the name of the single method but I just changed this to a compile time check instead.
| "google.golang.org/protobuf/types/known/timestamppb" | ||
| ) | ||
|
|
||
| const ( |
Contributor
There was a problem hiding this comment.
Why did this get removed?
Member
Author
There was a problem hiding this comment.
Mentioned in the description, it was unused and had the wrong value.
bergundy
force-pushed
the
nexus-chasm-cleanup
branch
from
f4acfd1 to
d8e3d03
Compare
bergundy
force-pushed
the
nexus-chasm-cleanup
branch
from
d8e3d03 to
8a58574
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
chasmpackage.Archetypeconstant.How did you test it?