Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently read requests for CHASM executions are returning "workflow execution not found" as the
NotFounderror message. Fix the message. It didn't look likeArchetypeexposes a string suitable for use here so I didn't try to do that.There is functional test coverage for this change in the standalone activities branch.
Note
Standardizes CHASM read NotFound errors to "execution not found" and adds a unit test to verify it.
NotFounderrors ingetExecutionLeaseforReadComponentby mapping toserviceerror.NewNotFound("execution not found")inservice/history/chasm_engine.go.TestReadComponent_NotFoundinservice/history/chasm_engine_test.goto assert the standardized message and ensure the read callback is not invoked.Written by Cursor Bugbot for commit c02270c. This will update automatically on new commits. Configure here.