Skip to content

Conversation

@dandavison
Copy link
Contributor

@dandavison dandavison commented Nov 25, 2025

Currently read requests for CHASM executions are returning "workflow execution not found" as the NotFound error message. Fix the message. It didn't look like Archetype exposes a string suitable for use here so I didn't try to do that.

There is functional test coverage for this change in the standalone activities branch.


Note

Standardizes CHASM read NotFound errors to "execution not found" and adds a unit test to verify it.

  • Backend (history):
    • Normalize NotFound errors in getExecutionLease for ReadComponent by mapping to serviceerror.NewNotFound("execution not found") in service/history/chasm_engine.go.
  • Tests:
    • Add TestReadComponent_NotFound in service/history/chasm_engine_test.go to assert the standardized message and ensure the read callback is not invoked.

Written by Cursor Bugbot for commit c02270c. This will update automatically on new commits. Configure here.

@dandavison dandavison force-pushed the chasm-not-found branch 4 times, most recently from 803132d to 5f35b19 Compare November 25, 2025 01:13
@dandavison dandavison marked this pull request as ready for review November 25, 2025 01:13
@dandavison dandavison requested review from a team as code owners November 25, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants