Fix handling of context errors #8702
Merged
+24
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
approved these changes
Nov 25, 2025
Contributor
rodrigozhou
left a comment
rodrigozhou
left a comment
There was a problem hiding this comment.
Please address the comments before merging.
Co-authored-by: Rodrigo Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Context cancelations are getting incorrectly translated to
Unavailableservice errors, which lead to Visibility Availability Alert false positives.This code change adds branches to check context error types before casting to the resulting
serviceerrorfor both ElasticSearch and SQL visibility stores.Why?
Separate client and service side errors.
How did you test it?