Bugfix SQL 1.1 schema change #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
requested review from
a team,
alexshtin,
mastermanu,
samarabbas and
vitarb
mastermanu
approved these changes
Oct 27, 2020
alexshtin
reviewed
Oct 27, 2020
alexshtin
reviewed
Oct 27, 2020
Comment on lines
+1
to
+2
| ALTER TABLE cluster_metadata ADD data BYTEA NOT NULL DEFAULT ''; | ||
| ALTER TABLE cluster_metadata ADD data_encoding VARCHAR(16) NOT NULL DEFAULT 'Proto3'; |
Contributor
There was a problem hiding this comment.
I think @vitarb didn't add these defaults intentionally.
Contributor
Author
There was a problem hiding this comment.
I think @vitarb didn't add these defaults intentionally.
without it, it will be broken during schema upgrade
Contributor
Author
There was a problem hiding this comment.
sequence to break (postgresql):
- checkout 1.0.0
- create DB & schema
- start server
- checkout 1.1 or 1.2
- upgrade schema -> break
2020/10/27 12:46:57 ---- Executing updates for version 1.1 ----
2020/10/27 12:46:57 ALTER TABLE cluster_metadata ADD data BYTEA NOT NULL;
2020/10/27 12:46:58 error executing CQL statement:pq: null value in column "data" violates not-null constraint
vitarb
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Schema upgrade error out due to missing default value
How did you test it?
Manually create schema & start server in 1.0.0 then upgrade schema to 1.2.x and start server for both MySQL and PostgreSQL
Potential risks
N/A