User metadata #2796
Merged
User metadata #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
GraceGardner
requested review from
a team,
Alex-Tideman and
rossedfort
as code owners
Collaborator
I think we should always split this, and show the empty state for Summary / Details or Current Details if they don't exist. Probably a good idea to add a link to the docs in the empty state to show them how to add it (if those docs exist...) |
Collaborator
Purely a design thing... but this feels a little bland. I'm not totally sure what it needs but doesn't feel quite polished, especially the current details side. |
rossedfort
reviewed
Jul 29, 2025
Alex-Tideman
reviewed
Aug 5, 2025
Alex-Tideman
reviewed
Aug 6, 2025
src/lib/components/workflow/metadata/workflow-current-details.svelte
Outdated
Show resolved
Hide resolved
Alex-Tideman
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds memo, search attributes, and user metadata tabs/pages.
Adds testing to make sure these three pages work.
Adds override for the markdown component.
Updates a little styling to the empty state component requested by design.
Screenshots (if applicable) 📸
Design Considerations 🎨
Reviewed by Ash previously. They are currently on PTO.
Testing 🧪
I was able to test that things render when expected.
Would like to be able to test that the correct text is showing up in the markdown iframes, but the research I found seemed to suggest it's a bad idea. Basically because you have to switch to the iframe's context it's hard to have reliable tests. Everything I reached said you can do it, but it's hard to write, maintain, and the results can be flakey and frustrating. Wondering if maybe I should test the rendering logic or something instead? Open to ideas.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
To test, you need a workflow with search attributes, memo, and user metadata added. I have edited some of the go samples to test against. If anyone wants that code I can share it. Also can use the mock data added to the integration test.
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
2994
Docs
Any docs updates needed?