-
Notifications
You must be signed in to change notification settings - Fork 119
feat: add workflow execution timeout #2939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Alex-Tideman
merged 3 commits into
temporalio:main
from
ArchishmanSengupta:add-wf-timeouts
Oct 22, 2025
Merged
feat: add workflow execution timeout #2939
Alex-Tideman
merged 3 commits into
temporalio:main
from
ArchishmanSengupta:add-wf-timeouts
Oct 22, 2025
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add workflowExecutionTimeout field to WorkflowExecutionConfig and WorkflowExecution types - Update workflow execution model to include timeout information from execution config - Add i18n string for workflow timeout display - Add TimeoutTestWorkflow for testing timeout functionality - Update workflow details component to display timeout information This enhancement allows users to see and understand workflow execution timeouts in the UI, improving visibility into workflow configuration and behavior.
|
@ArchishmanSengupta is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
please take a look |
Collaborator
|
Appreciate the PR! Code looks good, just going to double check with design to make sure the summary area isn't getting too busy. |
Contributor
Author
|
@Alex-Tideman any update from the design team? |
Contributor
Author
|
@Alex-Tideman any updates |
Alex-Tideman
approved these changes
Oct 20, 2025
Contributor
Author
|
@Alex-Tideman i fixed the tests, can you please check? |
Alex-Tideman
approved these changes
Oct 22, 2025
temporal-cicd bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
Auto-generated version bump from 2.41.0 to 2.42.0 Bump type: minor Changes included: - [`9d546ce9`](9d546ce) Remove type=number to allow strings for case of duration (#2951) - [`15ca4f29`](15ca4f2) Duration placeholder text (#2954) - [`ba38c205`](ba38c20) Fix and always show expand icon (#2953) - [`b87da956`](b87da95) Show workflow error alert for workflow task timed out events (#2947) - [`80dc291e`](80dc291) Add randomUUID polyfill (#2952) - [`11fdf6ee`](11fdf6e) refactor(forms): migrate search attributes and codec server forms to functional pattern (#2919) - [`c130db4c`](c130db4) style number input to match input (#2960) - [`5715d054`](5715d05) Bump vite from 6.2.7 to 6.4.1 (#2964) - [`e57365f3`](e57365f) Allow folding of JSON on very large JSON trees (#2967) - [`28897fa0`](28897fa) Use WorkflowExecutionStarted eventTime if before workflow executionTime (#2963) - [`e0b74362`](e0b7436) Add w-full to menu (#2962) - [`3c9543cf`](3c9543c) Show all structured calendars or intervals in schedule spec (#2968) - [`92d0742f`](92d0742) Add catchup window to schedule details (#2961) - [`e8dac23b`](e8dac23) add unique attributes to event details components (#2969) - [`6786bf65`](6786bf6) Bump go and rpc versions (#2970) - [`a4829b09`](a4829b0) fix(batch): uri encode batch job ids (#2946) - [`cd40943f`](cd40943) feat: add workflow execution timeout (#2939)
Alex-Tideman
added a commit
that referenced
this pull request
Oct 22, 2025
Auto-generated version bump from 2.41.0 to 2.42.0 Bump type: minor Changes included: - [`9d546ce9`](9d546ce) Remove type=number to allow strings for case of duration (#2951) - [`15ca4f29`](15ca4f2) Duration placeholder text (#2954) - [`ba38c205`](ba38c20) Fix and always show expand icon (#2953) - [`b87da956`](b87da95) Show workflow error alert for workflow task timed out events (#2947) - [`80dc291e`](80dc291) Add randomUUID polyfill (#2952) - [`11fdf6ee`](11fdf6e) refactor(forms): migrate search attributes and codec server forms to functional pattern (#2919) - [`c130db4c`](c130db4) style number input to match input (#2960) - [`5715d054`](5715d05) Bump vite from 6.2.7 to 6.4.1 (#2964) - [`e57365f3`](e57365f) Allow folding of JSON on very large JSON trees (#2967) - [`28897fa0`](28897fa) Use WorkflowExecutionStarted eventTime if before workflow executionTime (#2963) - [`e0b74362`](e0b7436) Add w-full to menu (#2962) - [`3c9543cf`](3c9543c) Show all structured calendars or intervals in schedule spec (#2968) - [`92d0742f`](92d0742) Add catchup window to schedule details (#2961) - [`e8dac23b`](e8dac23) add unique attributes to event details components (#2969) - [`6786bf65`](6786bf6) Bump go and rpc versions (#2970) - [`a4829b09`](a4829b0) fix(batch): uri encode batch job ids (#2946) - [`cd40943f`](cd40943) feat: add workflow execution timeout (#2939) Co-authored-by: Alex-Tideman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR adds support for displaying workflow execution timeouts in the Temporal UI. Previously, users could not see workflow execution timeout information in the workflow details view, making it difficult to understand and debug workflow configurations.
The changes include:
workflowExecutionTimeoutfield to type definitionsScreenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Manual Testing:
TimeoutTestWorkflowthat runs for 30 seconds to test timeout displaySteps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist