Skip to content

Conversation

@ArchishmanSengupta
Copy link
Contributor

Description & motivation 💭

This PR adds support for displaying workflow execution timeouts in the Temporal UI. Previously, users could not see workflow execution timeout information in the workflow details view, making it difficult to understand and debug workflow configurations.

The changes include:

  • Adding workflowExecutionTimeout field to type definitions
  • Updating the workflow execution model to parse timeout information from the execution config
  • Adding internationalization support for timeout display
  • Creating a test workflow to verify timeout functionality
  • Updating the workflow details component to show timeout information

Screenshots (if applicable) 📸

Screenshot 2025-10-08 at 2 10 34 AM

Design Considerations 🎨

  • The timeout information is displayed alongside other workflow configuration details
  • Uses consistent styling with existing workflow detail fields
  • Follows the established pattern for displaying duration values

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Manual Testing:

  • Created TimeoutTestWorkflow that runs for 30 seconds to test timeout display
  • Verified timeout information appears correctly in workflow details view
  • Tested with workflows that have and don't have execution timeouts set
  • Confirmed existing functionality remains unaffected

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  1. Start a workflow with an execution timeout configured
  2. Navigate to the workflow details page
  3. Verify that the "Workflow Timeout" field is displayed with the correct timeout value
  4. Test with workflows that don't have execution timeouts to ensure the field doesn't appear or shows as "Not set"
  5. Verify the timeout value is formatted correctly (e.g., "30s", "1m", "1h")

Checklists

Draft Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Lint-staged checks passed
  • Feature works as expected

Merge Checklist

  • Code review approved
  • All CI checks pass
  • Documentation updated if needed
  • Screenshots added to PR description

- Add workflowExecutionTimeout field to WorkflowExecutionConfig and WorkflowExecution types
- Update workflow execution model to include timeout information from execution config
- Add i18n string for workflow timeout display
- Add TimeoutTestWorkflow for testing timeout functionality
- Update workflow details component to display timeout information

This enhancement allows users to see and understand workflow execution timeouts
in the UI, improving visibility into workflow configuration and behavior.
@vercel
Copy link

vercel bot commented Oct 7, 2025

@ArchishmanSengupta is attempting to deploy a commit to the Temporal Team on Vercel.

A member of the Team first needs to authorize it.

@ArchishmanSengupta ArchishmanSengupta changed the title feat: add workflow execution timeout support feat: add workflow execution timeout Oct 7, 2025
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2025

CLA assistant check
All committers have signed the CLA.

@ArchishmanSengupta
Copy link
Contributor Author

@Alex-Tideman
@rossedfort

please take a look

@Alex-Tideman
Copy link
Collaborator

Appreciate the PR! Code looks good, just going to double check with design to make sure the summary area isn't getting too busy.

@ArchishmanSengupta
Copy link
Contributor Author

@Alex-Tideman any update from the design team?

@ArchishmanSengupta
Copy link
Contributor Author

@Alex-Tideman any updates

@ArchishmanSengupta
Copy link
Contributor Author

@Alex-Tideman i fixed the tests, can you please check?

@Alex-Tideman Alex-Tideman merged commit cd40943 into temporalio:main Oct 22, 2025
12 of 13 checks passed
temporal-cicd bot pushed a commit that referenced this pull request Oct 22, 2025
Auto-generated version bump from 2.41.0 to 2.42.0

Bump type: minor

Changes included:
- [`9d546ce9`](9d546ce) Remove type=number to allow strings for case of duration (#2951)
- [`15ca4f29`](15ca4f2) Duration placeholder text (#2954)
- [`ba38c205`](ba38c20) Fix and always show expand icon (#2953)
- [`b87da956`](b87da95) Show workflow error alert for workflow task timed out events (#2947)
- [`80dc291e`](80dc291) Add randomUUID polyfill (#2952)
- [`11fdf6ee`](11fdf6e) refactor(forms): migrate search attributes and codec server forms to functional pattern (#2919)
- [`c130db4c`](c130db4) style number input to match input (#2960)
- [`5715d054`](5715d05) Bump vite from 6.2.7 to 6.4.1 (#2964)
- [`e57365f3`](e57365f) Allow folding of JSON on very large JSON trees (#2967)
- [`28897fa0`](28897fa) Use WorkflowExecutionStarted eventTime if before workflow executionTime (#2963)
- [`e0b74362`](e0b7436) Add w-full to menu (#2962)
- [`3c9543cf`](3c9543c) Show all structured calendars or intervals in schedule spec (#2968)
- [`92d0742f`](92d0742) Add catchup window to schedule details (#2961)
- [`e8dac23b`](e8dac23) add unique attributes to event details components (#2969)
- [`6786bf65`](6786bf6) Bump go and rpc versions (#2970)
- [`a4829b09`](a4829b0) fix(batch): uri encode batch job ids (#2946)
- [`cd40943f`](cd40943) feat: add workflow execution timeout (#2939)
Alex-Tideman added a commit that referenced this pull request Oct 22, 2025
Auto-generated version bump from 2.41.0 to 2.42.0

Bump type: minor

Changes included:
- [`9d546ce9`](9d546ce) Remove type=number to allow strings for case of duration (#2951)
- [`15ca4f29`](15ca4f2) Duration placeholder text (#2954)
- [`ba38c205`](ba38c20) Fix and always show expand icon (#2953)
- [`b87da956`](b87da95) Show workflow error alert for workflow task timed out events (#2947)
- [`80dc291e`](80dc291) Add randomUUID polyfill (#2952)
- [`11fdf6ee`](11fdf6e) refactor(forms): migrate search attributes and codec server forms to functional pattern (#2919)
- [`c130db4c`](c130db4) style number input to match input (#2960)
- [`5715d054`](5715d05) Bump vite from 6.2.7 to 6.4.1 (#2964)
- [`e57365f3`](e57365f) Allow folding of JSON on very large JSON trees (#2967)
- [`28897fa0`](28897fa) Use WorkflowExecutionStarted eventTime if before workflow executionTime (#2963)
- [`e0b74362`](e0b7436) Add w-full to menu (#2962)
- [`3c9543cf`](3c9543c) Show all structured calendars or intervals in schedule spec (#2968)
- [`92d0742f`](92d0742) Add catchup window to schedule details (#2961)
- [`e8dac23b`](e8dac23) add unique attributes to event details components (#2969)
- [`6786bf65`](6786bf6) Bump go and rpc versions (#2970)
- [`a4829b09`](a4829b0) fix(batch): uri encode batch job ids (#2946)
- [`cd40943f`](cd40943) feat: add workflow execution timeout (#2939)

Co-authored-by: Alex-Tideman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants