feat(search-attributes): add isDeletable #3041
Open
+51
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove hideDeleteButton prop from search attributes form components - Add isExisting flag to SearchAttributeDefinition to track existing vs new rows - Disable delete button for existing attributes while allowing deletion of newly added unsaved rows - Update Zod schema to include optional isExisting field
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
isExisting is UI-only metadata and doesn't need validation
…Forms from stripping it The root cause was SuperForms removing properties not defined in the validation schema. By adding isExisting to the Zod schema with .optional().default(false), SuperForms now preserves the flag correctly throughout the component lifecycle.
Rename property from isExisting to isDeletable with inverted logic for better semantic clarity. Now isDeletable: true means the row can be deleted (new rows) and isDeletable: false means it cannot be deleted (existing rows).
…ults Make isDeletable optional with a default value of true in the component props, removing the need to map over initial attributes to add the flag. Callers are now responsible for explicitly setting isDeletable: false on existing attributes.
rossnelson
changed the title
rossnelson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the search attributes form to disable (rather than hide) the delete button for existing attributes. Users can still add new rows and delete them if they haven't been saved to the server yet.
Changes
hideDeleteButtonprop from search attributes form componentsisDeletableflag toSearchAttributeDefinitionto track whether rows can be deletedisDeletablefield (defaults totruefor new rows,falsefor existing)Implementation Details
The
isDeletableproperty uses positive logic:isDeletable: true- Row can be deleted (new, unsaved rows)isDeletable: false- Row cannot be deleted (existing, saved attributes)This property must be included in the Zod schema to prevent SuperForms from stripping it during form state updates.
Behavior
isDeletable: false)isDeletable: true)isDeletable: true)Test Plan