Skip to content

feat: support install.go()#2055

Merged
kemingy merged 3 commits intotensorchord:mainfrom
kemingy:install_go
Nov 7, 2025
Merged

feat: support install.go()#2055
kemingy merged 3 commits intotensorchord:mainfrom
kemingy:install_go

Conversation

@kemingy
Copy link
Copy Markdown
Member

@kemingy kemingy commented Nov 6, 2025

No description provided.

Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for installing the Go programming language in the envd build system. The implementation follows the existing patterns established for other language installations like Rust and Julia.

  • Introduces a new install.go() function to install Go with optional version specification
  • Implements Go installation by downloading from official Go releases and extracting to /usr/local/go
  • Refactors Rust constants to follow unexported naming conventions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/lang/ir/v1/golang.go New file implementing Go installation logic with download and extraction
pkg/lang/ir/v1/system.go Adds "go" case to language compilation switch statements
pkg/lang/ir/v1/rust.go Refactors exported constants to unexported following Go conventions
pkg/lang/ir/v1/interface.go Adds public Golang() function to register Go language in the graph
pkg/lang/frontend/starlark/v1/install/install.go Registers the install.go Starlark function and its implementation
pkg/lang/frontend/starlark/v1/install/const.go Adds ruleGo constant for the install.go rule name
envd/api/v1/install.py Adds Python API documentation for the go() installation function
e2e/language/testdata/golang/build.envd Test configuration file for Go installation e2e test
e2e/language/other_test.go Adds e2e test case for Go installation verification
Comments suppressed due to low confidence (1)

pkg/lang/ir/v1/system.go:191

  • The 'go' case is missing in the non-DisableMergeOp code path (lines 180-192). When DisableMergeOp is false, Go installation will be silently skipped. Add a case for 'go' that calls lang = g.installGolang(root, language.Version) to match the implementation in the DisableMergeOp branch.
			lang = g.installRust(root, language.Version)
		}
		langs = append(langs, lang)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy requested a review from Copilot November 6, 2025 01:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kemingy kemingy merged commit 7b11a87 into tensorchord:main Nov 7, 2025
26 of 27 checks passed
@kemingy kemingy deleted the install_go branch November 7, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants