feat: support install.go()#2055
Merged
kemingy merged 3 commits intotensorchord:mainfrom Nov 7, 2025
Merged
Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for installing the Go programming language in the envd build system. The implementation follows the existing patterns established for other language installations like Rust and Julia.
- Introduces a new
install.go()function to install Go with optional version specification - Implements Go installation by downloading from official Go releases and extracting to
/usr/local/go - Refactors Rust constants to follow unexported naming conventions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/lang/ir/v1/golang.go | New file implementing Go installation logic with download and extraction |
| pkg/lang/ir/v1/system.go | Adds "go" case to language compilation switch statements |
| pkg/lang/ir/v1/rust.go | Refactors exported constants to unexported following Go conventions |
| pkg/lang/ir/v1/interface.go | Adds public Golang() function to register Go language in the graph |
| pkg/lang/frontend/starlark/v1/install/install.go | Registers the install.go Starlark function and its implementation |
| pkg/lang/frontend/starlark/v1/install/const.go | Adds ruleGo constant for the install.go rule name |
| envd/api/v1/install.py | Adds Python API documentation for the go() installation function |
| e2e/language/testdata/golang/build.envd | Test configuration file for Go installation e2e test |
| e2e/language/other_test.go | Adds e2e test case for Go installation verification |
Comments suppressed due to low confidence (1)
pkg/lang/ir/v1/system.go:191
- The 'go' case is missing in the non-DisableMergeOp code path (lines 180-192). When DisableMergeOp is false, Go installation will be silently skipped. Add a case for 'go' that calls
lang = g.installGolang(root, language.Version)to match the implementation in the DisableMergeOp branch.
lang = g.installRust(root, language.Version)
}
langs = append(langs, lang)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.