feat: support --cap for envd up#2078
Merged
kemingy merged 2 commits intotensorchord:mainfrom Jan 28, 2026
Merged
Conversation
This adds the cap to the root user, but the `envd` user cannot inherit the cap. Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the --cap flag to the envd up command, allowing users to add Linux capabilities to containers. However, there's also an unrelated version bump for the Codex agent included in the changes.
Changes:
- Added
--capCLI flag to accept capability specifications - Extended StartOptions struct to include Capabilities field
- Modified Docker engine to apply capabilities to container host configuration
- Updated Codex default version from 0.79.0 to 0.92.0 (unrelated change)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/lang/ir/v1/agent.go | Updated Codex default version (appears unrelated to capabilities feature) |
| pkg/envd/types.go | Added Capabilities field to StartOptions struct |
| pkg/envd/docker.go | Added capability handling in Docker container creation and logging |
| pkg/app/up.go | Added --cap CLI flag and wired it to StartOptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Keming <kemingyang@tensorchord.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the cap to the root user, but the
envduser cannot inherit the cap.