Skip to content

Tensorflow 2.0: resampler not available #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ltrottier opened this issue Oct 1, 2019 · 5 comments
Closed

Tensorflow 2.0: resampler not available #640

ltrottier opened this issue Oct 1, 2019 · 5 comments

Comments

@ltrottier
Copy link

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template

System information

  • TensorFlow version (you are using): 2.0
  • Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.

I would like tensorflow.contrib.resampler.resampler to be available in TF 2.0. Or, any alternative that allows to interpolate a 2D grid at real coordinates.

Will this change the current api? How?

Yes, it will add a new function.

Who will benefit with this feature?

I was using resampler to optimize ROIAlign (of Mask-RCNN) with rotated bounding boxes (and masks). Instead of doing rotate -> crop -> resize to pool the rotated masks, I directly fetched it with resampler. It was about 2-3x faster.

So anyone who wants to pool random locations in a 2D grid (mostly for instance segmentation I think) could benefit from it.

Any Other info.

@MrSorrow
Copy link

So, have you solved this problem?

@sipposip
Copy link

I use resampler in an application for a special type of spherical convolution. It would be non-trivial (and potentially slow) to do this with other available ops.

@dynamicwebpaige
Copy link
Contributor

Though this functionality is outside of the scope of TensorFlow Core in the near term, it might be a good fit for TensorFlow Addons. If we see sufficient traction in Addons, then the symbol could be migrated to tensorflow/tensorflow.

Rerouting this feature request to the addons repo; @seanpmorgan for visibility.

@dynamicwebpaige dynamicwebpaige transferred this issue from tensorflow/tensorflow Oct 29, 2019
@seanpmorgan
Copy link
Member

This seems like it would fit within tfa.image. Happy to review a PR for this feature migrated from:
https://github.com/tensorflow/tensorflow/tree/v1.15.0/tensorflow/contrib/resampler

@WindQAQ
Copy link
Member

WindQAQ commented Nov 25, 2019

Closes via #662.

@WindQAQ WindQAQ closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants