-
Notifications
You must be signed in to change notification settings - Fork 614
add resampler kernel #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resampler kernel #662
Conversation
Hi @WindQAQ, can you help review when you are available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Generally LGTM!
tensorflow_addons/custom_ops/image/cc/kernels/resampler_ops_gpu.cu.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I drop some comments down below. Please check it out.
Thanks @WindQAQ. I've updated new patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run make code-format
again and check make sanity-check
? Sometimes code won't be formatted util committing changes.
tensorflow_addons/custom_ops/image/cc/kernels/adjust_hsv_in_yiq_op.cc
Outdated
Show resolved
Hide resolved
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
} // namespace tensorflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert the change of this line? I mean do not make any change to this file actually :-) Thanks.
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks @WindQAQ. I've tried it again. It may work now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Address issue #640, resampler kernel