Skip to content

add resampler kernel #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 25, 2019
Merged

add resampler kernel #662

merged 14 commits into from
Nov 25, 2019

Conversation

autoih
Copy link
Member

@autoih autoih commented Nov 4, 2019

Address issue #640, resampler kernel

@autoih autoih changed the title [WIP] add resampler kernel add resampler kernel Nov 5, 2019
@autoih
Copy link
Member Author

autoih commented Nov 5, 2019

Hi @WindQAQ, can you help review when you are available?

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Generally LGTM!

@autoih autoih requested a review from WindQAQ November 11, 2019 20:28
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I drop some comments down below. Please check it out.

@autoih autoih requested a review from WindQAQ November 21, 2019 23:33
@autoih
Copy link
Member Author

autoih commented Nov 22, 2019

Hi @WindQAQ, I block the part, which cannot be tested successfully. May I have your suggestions? Thank you.

@autoih autoih requested a review from WindQAQ November 23, 2019 04:55
@autoih
Copy link
Member Author

autoih commented Nov 23, 2019

Thanks @WindQAQ. I've updated new patch.

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make code-format again and check make sanity-check? Sometimes code won't be formatted util committing changes.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

} // namespace tensorflow
Copy link
Member

@WindQAQ WindQAQ Nov 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the change of this line? I mean do not make any change to this file actually :-) Thanks.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@autoih
Copy link
Member Author

autoih commented Nov 25, 2019

Thanks @WindQAQ. I've tried it again. It may work now. :)

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@WindQAQ WindQAQ merged commit 085503a into tensorflow:master Nov 25, 2019
@autoih autoih deleted the kernelrs branch February 9, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants