Skip to content

Faster tests when running locally. #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2020
Merged

Faster tests when running locally. #1030

merged 5 commits into from
Feb 9, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse commented Feb 6, 2020 •
edited
Loading

We make here efficient use of the docker cache to avoid having to download every time tensorflow. The tests also run in an isolated environement, which avoids polluting the project directory.

The command that google's CI runs for gpu tests is /bin/bash tools/run_docker.sh -s linux -d gpu -c 'make gpu-unit-test'.

Can we change that to /bin/bash tools/run_google_cloud_tests.sh? So that it's possible to modify it later on with pull requests?

@gabrieldemarmiesse gabrieldemarmiesse requested a review from a team as a code owner February 6, 2020 20:02
@boring-cyborg boring-cyborg bot added the github label Feb 6, 2020
@seanpmorgan seanpmorgan added the blocked Pending something elses completion label Feb 6, 2020
seanpmorgan
seanpmorgan reviewed Feb 6, 2020
View reviewed changes
seanpmorgan
seanpmorgan requested changes Feb 6, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall its a nice change for speedup. I would like to open this up to the Addons community to see if there are any thoughts on removing the makefile. I agree it's a bit unnecessary after the changes that have been made in the past few weeks.

@gabrieldemarmiesse
Copy link
Member Author

gabrieldemarmiesse commented Feb 6, 2020 •
edited
Loading

I don't know why I removed the makefile. Let me bring it back to life.

@gabrieldemarmiesse gabrieldemarmiesse mentioned this pull request Feb 6, 2020
Closed
seanpmorgan
seanpmorgan requested changes Feb 9, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So thinking about this a little more, could you keep run_docker.sh file that way we can merge this PR and file a new issue to switch the script for GPU testing.

After that's complete we'll be able to remove it.

@seanpmorgan seanpmorgan removed the blocked Pending something elses completion label Feb 9, 2020
seanpmorgan
seanpmorgan approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks again!

@seanpmorgan seanpmorgan merged commit fb316ff into tensorflow:master Feb 9, 2020
@gabrieldemarmiesse gabrieldemarmiesse deleted the use_build branch March 8, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @seanpmorgan @googlebot