Skip to content

Gathering the install code to make it easier to update versions. #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

Gathering the install code to make it easier to update versions. #1106

merged 1 commit into from
Feb 19, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

No description provided.

@gabrieldemarmiesse gabrieldemarmiesse requested a review from a team as a code owner February 18, 2020 16:58
@boring-cyborg boring-cyborg bot added the build label Feb 18, 2020
seanpmorgan
seanpmorgan reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up! Should we use this set-up bazel repository within our build scripts as well?

seanpmorgan
seanpmorgan approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it a bit more, I'm not sure we should use a non-certified GitHub action in our builds for security reasons.

@seanpmorgan seanpmorgan merged commit 408452e into tensorflow:master Feb 19, 2020
@gabrieldemarmiesse gabrieldemarmiesse deleted the drudru branch March 8, 2020 16:32
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@gabrieldemarmiesse
Gathering the install code to make it easier to update versions. (ten…
5921a06 
…sorflow#1106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees
No one assigned
Labels
build cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @seanpmorgan @googlebot