Skip to content

Test in eager model #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 30, 2019
Merged

Test in eager model #695

merged 8 commits into from
Nov 30, 2019

Conversation

autoih
Copy link
Member

@autoih autoih commented Nov 12, 2019 •
edited
Loading

To be consistent with all tests in optimizers, layers, etc; replacing run_in_graph_and_eager_modes (only supports test methods) by run_all_in_graph_and_eager_modes.

@autoih autoih requested a review from seanpmorgan as a code owner November 12, 2019 21:02
seanpmorgan
seanpmorgan previously requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall thanks very much for the clean-up. Couple of comment and questions below.

@autoih autoih requested a review from seanpmorgan November 14, 2019 02:21
Squadrick
Squadrick suggested changes Nov 14, 2019
View reviewed changes
@autoih autoih requested a review from Squadrick November 14, 2019 15:53
@autoih
Copy link
Member Author

autoih commented Nov 22, 2019 •
edited
Loading

Thanks @Squadrick and @seanpmorgan. The new commit uses run_all_in_graph_and_eager_modes for all test. Can you help review when you are available?

Squadrick
Squadrick approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@autoih Thanks for the PR. LGTM.

cc: @seanpmorgan

@Squadrick Squadrick dismissed seanpmorgan’s stale review November 28, 2019 07:00

Changes requested have been made.

@autoih
Copy link
Member Author

autoih commented Nov 28, 2019

Thanks @Squadrick and @seanpmorgan for the suggestions.

@seanpmorgan seanpmorgan merged commit ea4c459 into tensorflow:master Nov 30, 2019
@autoih autoih deleted the tstuil branch February 9, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Squadrick Squadrick Squadrick approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@autoih @seanpmorgan @Squadrick @googlebot @kokoro-team